docs: update model selection compatibility - #1521
Conversation
This comment has been minimized.
This comment has been minimized.
chaodu-agent
left a comment
There was a problem hiding this comment.
Important
CHANGES REQUESTED
Consolidated review: #1521 (comment)
|
Addressed both Round 1 findings in commit F1 — Keep Gemini and Antigravity as distinct backends
F2 — Reconcile the OpenCode statement in the Slack guide
Validation
Please re-review commit |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Important
CHANGES REQUESTED
Consolidated review: #1521 (comment)
|
Addressed the Round 2 authentication finding in commit F1 — Qualify Gemini authentication after the June 18 transitionUpdated the
This removes the contradiction between the migration notice and the later authentication instructions. Validation
Please re-review commit |
This comment has been minimized.
This comment has been minimized.
chaodu-agent
left a comment
There was a problem hiding this comment.
Important
CHANGES REQUESTED
Consolidated review: #1521 (comment)
| | claude-code | ❌ No `configOptions` emitted | ❌ | | ||
| | codex | ❌ | ❌ | | ||
| | gemini | ❌ | ❌ | | ||
| | gemini (legacy) | ❌ No `configOptions` emitted; individual-account access ended June 18, 2026, while Enterprise and API-key access remain supported | ❌ | |
There was a problem hiding this comment.
🟡 F1 - Separate backend lifecycle from account-access policy
gemini (legacy) reads as if the backend itself is deprecated, but OpenAB still ships and documents Gemini for supported Enterprise/Google Cloud and API-key users. This cell also duplicates the June 18 policy details already sourced in docs/gemini.md, which makes the quick-reference table harder to scan and creates a second policy source that can drift.
Requested change: keep the agent name as gemini, describe only its /models capability here (for example, No configOptions emitted), and link to docs/gemini.md for account availability and migration details.
|
Note LGTM ✅ - The latest head resolves the remaining Gemini taxonomy and PR-contract issues, and the changed compatibility guidance is supported by the reviewed sources and explicit evidence caveats. What This PR DoesThis PR updates How It WorksThe documentation describes ACP Findings
Finding Details🟢 F1: Keep backend identity separate from account policyCommit 🟢 F2: Antigravity guidance matches the adapter contractThe local adapter fetches 🟢 F3: Residual evidence risk is explicitOpenCode is tied to the repository's pinned v1.17.9 source and tests. Devin is described as ACP client evidence with a pending live OpenAB capture. These caveats are also present in the PR contract, so readers can distinguish verified behavior from follow-up validation. Baseline Check
Addressing External Reviewer FeedbackRound 1
✅ Addressed in
✅ Addressed in Round 2
✅ Addressed in Round 3
✅ Addressed in
✅ Addressed in the current PR body: the goal, non-goals, residual risks, acceptance criteria, validation, five-file scope, and four introduced links now match the reviewed result; the empty @agent-rapi
✅ Confirmed: all claimed fixes remain present at the exact reviewed head, and the final Round 3 fixes complete the documented review contract. Reviewer Coverage
Validation
What's Good (🟢)
5. Three Reasons We Might Not Need This PR
|
There was a problem hiding this comment.
Note
LGTM ✅ - All earlier review findings are resolved at the exact reviewed head, and the changed documentation is source-aligned with explicit residual-risk caveats.
Consolidated review: #1521 (comment)
What problem does this solve?
The
/modelscompatibility table omits supported backends, does not distinguish Gemini CLI from Antigravity, and does not match current ACP model-selection behavior. The Antigravity guide also lacks model-selection instructions, the Devin guide refers to a non-existent/modelDiscord command, and the Slack guide contains a stale OpenCode capability statement.Discord Discussion URL: https://discord.com/channels/1491295327620169908/1491365157010542652/1544999250000089118
Review Contract
Goal
Correct and complete the
/modelscompatibility table for Gemini, Antigravity, OpenCode, and Devin; document Antigravity model selection; correct Devin's slash-command reference; centralize Gemini account-migration guidance; and reconcile the Slack guide with current OpenCode behavior.Non-goals
Accepted Residual Risks
docs/gemini.mdis the canonical migration source linked from the compatibility table.Acceptance Criteria
slash-commands.mdincludes distinct Gemini, Antigravity, OpenCode, and Devin rows.antigravity.mdexplains/models, live model fetching, cache/fallback behavior, anddefault_config_options.devin.mdreferences/modelsand states the live-verification caveat.slack.mdlinks to the central compatibility table instead of duplicating backend claims.Follow-ups
/agentsif OpenAB maps ACP'smodecategory to itsagentcategory in the future.At a Glance
N/A - docs-only.
Prior Art & Industry Research
Not applicable - this is a documentation-only correction of existing ACP behavior and vendor account guidance.
OpenClaw: Not applicable - no architectural or runtime change.
Hermes Agent: Not applicable - no architectural or runtime change.
Other references (optional): OpenCode v1.17.9 ACP
service.tsandconfig-option.ts; OpenAB'sagy-acpadapter; Gemini CLI maintainer transition announcements.Proposed Solution
docs/gemini.md, linked from the quick-reference table./modelreference to/modelsand document the evidence boundary.Why this approach?
It keeps the change docs-only, preserves supported backend identities, and aligns the documentation with the versions and adapter code currently shipped by OpenAB. Explicit caveats distinguish source verification from end-to-end live verification, while links avoid duplicating vendor-policy details across documents.
Alternatives Considered
configOptionsand handles model configuration changes.Validation
git diff --checkpasses.agy-acpsource, OpenAB config-option parsing, pinned OpenCode v1.17.9 upstream ACP source, the existing Devin guide, and Gemini CLI maintainer announcements.